Opened 8 years ago

Last modified 8 years ago

#222 new task

Remove __declspec(thread) code - it's not used and also sligthly dangerous

Reported by: marcusl Owned by: vossg
Priority: observe Milestone: 2.0 Beta
Component: System Version: 2.0
Keywords: Cc:

Description

See the declspec(thread) section in this page for some explanation of the issues.

Change History (2)

comment:1 Changed 8 years ago by vossg

  • Milestone set to 2.0 Beta
  • Owner changed from unassigned to vossg
  • Priority changed from major to observe

hmm, it is a compile time option, so I would leave it in there and maybe set the default to the safe TLS based version, though you will get a performance penalty.

comment:2 Changed 8 years ago by marcusl

As per the discussion on the mail-list, going safe feels like a good idea, and the performance penalty ought to be reduced in 2.0, as we don't have MTPtrs everwhere.

I'm a bit worried since OSGFileIO needs to be loaded explicitly (OSG::preloadsharedlib(), i.e. LoadLibrary?) on windows, so statically stored thread values there won't work.

We (i.e. I) should run some tests and see what the effects are, performance and stability wise.

Note: See TracTickets for help on using tickets.